docs: remove links to deleted OAuth examples; fix migration-guide cross-references - #2679
docs: remove links to deleted OAuth examples; fix migration-guide cross-references#2679ZayanKhan-12 wants to merge 4 commits into
Conversation
examples/oauth-v2 and examples/oauth-v1 no longer exist in the repository (only openid-connect and socket-mode remain), so both links 404. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The linked examples/oauth-v2 and examples/oauth-v1 directories were removed from the repository; both GitHub URLs return 404. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- the requestInterceptor reference was missing the '#' and used a slug that matches no heading; point at the actual section anchor - the socket-mode v3 guide linked ./web-api-v8-migration.md, which does not exist; the guide lives at ../web-api/migrating-web-api-package-to-v8.md Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 18e34df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @zk-khan to sign the Salesforce Inc. Contributor License Agreement. |
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for this fix 💯
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 89.11% 89.25% +0.13%
==========================================
Files 65 65
Lines 10339 10339
Branches 471 471
==========================================
+ Hits 9214 9228 +14
+ Misses 1095 1084 -11
+ Partials 30 27 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lukegalbraithrussell
left a comment
lukegalbraithrussell
left a comment
There was a problem hiding this comment.
Docs changes are good! Thank you!
|
@ZayanKhan-12 these changes are ready to merge 🚀 but I'm unable to merge this until you've signed the CLA |
Removed links to deleted OAuth examples and fixed cross-references in the migration guide.
4 participants
Three commits:
packages/oauth/README.md— the Examples section links../../examples/oauth-v2and../../examples/oauth-v1, but those example apps were removed from the repository (onlyopenid-connectandsocket-moderemain), so both links 404. Removed the dead section.docs/english/oauth.md— the same two examples linked as absolute GitHub URLs; both curl 404 (the parentexamples/tree is 200). Removed.requestInterceptorcross-reference was missing the#and used a slug matching no heading (now points at the real#weve-removed-the-requestinterceptor-and-requestinterceptor-typesanchor, heading present in the same file), and the socket-mode v3 guide linked./web-api-v8-migration.md, which doesn't exist anywhere (now../web-api/migrating-web-api-package-to-v8.md).Verification: all dead targets confirmed missing (tree + curl), all corrected targets confirmed present; root
npm run buildand the touched package's suite (npm test --workspace=packages/oauth) pass locally — 16/16 tests (Node 22, macOS arm64).Prepared with AI assistance (Claude).